Skip to content

Fix snapshot deps resolution #21912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix snapshot deps resolution #21912

wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

As part of 8e85487, snapshot dependency resolution change from
BUILD-SNAPSHOT to -SNAPSHOT. Currently, if we add a version
dependency which is store in snapshots it is not resolved. This
commit allow to resolves plugins and dependencies.

@eddumelendez
Fix snapshot deps resolution
31698d4 
As part of 8e85487, snapshot dependency resolution change from
`BUILD-SNAPSHOT` to `-SNAPSHOT`. Currently, if we add a version
dependency which is store in snapshots it is not resolved. This
commit allow to resolves plugins and dependencies.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 14, 2020
@wilkinsona wilkinsona self-assigned this Jun 15, 2020
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 15, 2020
@wilkinsona wilkinsona added this to the 2.4.0-M1 milestone Jun 15, 2020
wilkinsona pushed a commit that referenced this pull request Jun 15, 2020
@eddumelendez @wilkinsona
Fix detection of snapshot version when configuring repositories
20f05f4 
As part of 8e85487, snapshot dependency resolution change from
`BUILD-SNAPSHOT` to `-SNAPSHOT`. Currently, if we add a version
dependency which is store in snapshots it is not resolved. This
commit allow to resolves plugins and dependencies.

See gh-21912
wilkinsona added a commit that referenced this pull request Jun 15, 2020
@wilkinsona
Polish "Fix detection of snapshot version when configuring repositories"
2990b69 
See gh-21912
@wilkinsona
Copy link
Member

Thanks very much, @eddumelendez. I tweaked your proposal a little bit to look for -SNAPSHOT rather than just SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
2.4.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@eddumelendez @wilkinsona @spring-projects-issues